[PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 07:18:43 PDT 2016

aaron.ballman added inline comments.

Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79
@@ -69,3 +78,3 @@
     for (const auto &KeyValue :
          std::vector<std::pair<llvm::StringRef, std::string>>(
              {{"fenv.h", "cfenv"},
omtcyfz wrote:
> aaron.ballman wrote:
> > This will definitely fail in MSVC 2013.
> See the left side of `diff`. It already is in source tree, buildbots never complained.
> Thus, it won't.
Ah shoot, I was misremembering a different case with a similar construct, except it was using std::make_pair, which caused deduction to fail. Le sigh.


More information about the cfe-commits mailing list