[PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 6 16:27:17 PDT 2016


omtcyfz added a comment.

`.cpp.rename-at.yaml`? I understand it's done for the purpose of doing `-input %s.rename-at.yaml`, though I don't think getting proper names for them and either doing some string magic in tool invocation or just passing full name is wrong.

Other than that my concerns seem to be resolved. I'd wait for Manuel to jump in if he has time on Monday, though.


https://reviews.llvm.org/D23198





More information about the cfe-commits mailing list