[PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

Miklos Vajna via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 5 12:34:13 PDT 2016

vmiklos marked 2 inline comments as done.
vmiklos added a comment.

> Would also be nice to support at least `offset + new-name` in YAML input files, too.


> Please move this block upwards [preferably right after line 42]. I consider

>  information about limitations and editor more important than numerous

>  clang-rename's terminal interface invocation examples.

Makes sense, done. I wouldn't mind if rename-all wouldn't be advertised (apart
from dumping the options) at all in the documentation, but then users would
have to look at the source code for what is the wanted YAML format, and *that*
would be bad, I guess. ;-)

> https://reviews.llvm.org/D23158 introduces simpler clang-rename invocations

>  in tests. Please do that here, too.



More information about the cfe-commits mailing list