[PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

Aditya Kumar via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 3 05:23:34 PDT 2016

hiraditya added a comment.

In https://reviews.llvm.org/D22782#504416, @EricWF wrote:

> The change itself LGTM, although we probably want to inline the forward/input iterator __init's as well.
> However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark.
>  Some helpful links:
> - http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchmarks
> - http://github.com/google/benchmark

We'll come up with a synthetic benchmark to expose performance improvements.



More information about the cfe-commits mailing list