[PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 22:33:11 PDT 2016


EricWF added a subscriber: EricWF.
EricWF added a comment.

The change itself LGTM, although we probably want to inline the forward/input iterator __init's as well.

However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark.
Some helpful links:

- http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchmarks
- http://github.com/google/benchmark


https://reviews.llvm.org/D22782





More information about the cfe-commits mailing list