[PATCH] D20811: [analyzer] Model some library functions

Alexander Droste via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 30 12:19:07 PDT 2016


Alexander_Droste added a comment.

> It has been originally written as a large set of files. If you feel strongly about it, we could merge it into a single file. That makes sense to me. @Alexander_Droste, what do you think?


Hi, 
I would still strongly prefer to keep them in separate files if possible. One of the headers (`MPIFunctionClassifier.hpp`)
also got moved to `include/clang/StaticAnalyzer/Checkers`, as it is needed by some MPI clang-tidy checks. 
Is it really a problem if the checker comments are part of the Doxygen documentation? Further, I think that
the separation of concerns in form of distinct files might be valuable for people being new to the Clang Static Analyzer
framework, as the grouping of functionality is visible on a higher level of abstraction. Regardless, I would of course
accept if you prefer to merge the files into a single one, excluding the `MPIFunctionClassifier.hpp` header.


https://reviews.llvm.org/D20811





More information about the cfe-commits mailing list