[PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 11:16:36 PDT 2016

aaron.ballman added a comment.

In http://reviews.llvm.org/D22190#479921, @mgehre wrote:

> Even if we change isIntegerConstantExpr() to return true instead of asserting, we still need this fix to the check. Because
>  we call isIntegerConstantExpr() to find out if we can possibly calculate the (constant) value of the index expression.
>  If it is value dependent, we cannot.

You can on instantiation, can you not?


More information about the cfe-commits mailing list