[PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

Matthias Gehre via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 01:04:59 PDT 2016


mgehre added a comment.

Even if we change isIntegerConstantExpr() to return true instead of asserting, we still need this fix to the check. Because
we call isIntegerConstantExpr() to find out if we can possibly calculate the (constant) value of the index expression.
If it is value dependent, we cannot.


http://reviews.llvm.org/D22190





More information about the cfe-commits mailing list