[PATCH] D20404: [Driver] Fix driver support for color diagnostics
Duncan P. N. Exon Smith via cfe-commits
cfe-commits at lists.llvm.org
Wed May 18 19:01:11 PDT 2016
I don't think we even need a helper.
Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`.
In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) now that you've changed clang::ParseDiagnosticArgs to update `DiagnosticsOptions`.
> On 2016-May-18, at 18:54, Sean Silva <chisophugis at gmail.com> wrote:
> silvas added a subscriber: silvas.
> silvas added a comment.
> I don't see an issue with putthing this as a helper in libBasic. We may need to add a libOption dependency to it but that sounds fine.
More information about the cfe-commits