[PATCH] D20404: [Driver] Fix driver support for color diagnostics

Duncan P. N. Exon Smith via cfe-commits cfe-commits at lists.llvm.org
Wed May 18 19:01:10 PDT 2016

dexonsmith added a comment.

I don't think we even need a helper.

Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`.

In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) now that you've changed clang::ParseDiagnosticArgs to update `DiagnosticsOptions`.


More information about the cfe-commits mailing list