[PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

don hinton via cfe-commits cfe-commits at lists.llvm.org
Thu May 12 14:31:32 PDT 2016


hintonda added inline comments.

================
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:99
@@ +98,3 @@
+          if (Tok.is(tok::l_paren)) {
+            Tok = getPreviousNonCommentToken(Context, Tok.getLocation());
+            found = std::string(GetText(Tok, SM)) + "(true)";
----------------
Sorry, I mis-typed.  I meant to say I had, and prefer, "const FunctionDecl*" to "const auto *" in cases like this, but will do whatever you want.

================
Comment at: clang-tidy/utils/LexerUtils.cpp:38
@@ -37,1 +37,3 @@
 
+SmallVector<Token, 16> ParseTokens(const ASTContext &Context,
+                                   const SourceManager &Sources,
----------------
etienneb wrote:
> If you call ParseTokens, it will parse tokens until it reach a semicolon/lbrace? exact?
> 
Yes, but again, I'm not sure what you are asking me to do/change.

Are you asking me to change something?


http://reviews.llvm.org/D18575





More information about the cfe-commits mailing list