[PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Thu May 12 14:16:19 PDT 2016


etienneb added inline comments.

================
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:98
@@ +97,3 @@
+  const auto *FuncDecl = Result.Nodes.getNodeAs<FunctionDecl>("functionDecl");
+  if (!FuncDecl)
+    return;
----------------
I'm not saying to use 'const *FuncDecl', but 'const auto*'

================
Comment at: clang-tidy/utils/LexerUtils.cpp:38
@@ -37,1 +37,3 @@
 
+SmallVector<Token, 16> ParseTokens(const ASTContext &Context,
+                                   const SourceManager &Sources,
----------------
If you call ParseTokens, it will parse tokens until it reach a semicolon/lbrace? exact?



http://reviews.llvm.org/D18575





More information about the cfe-commits mailing list