[PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 04:26:09 PST 2016

Anastasia added inline comments.

Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:24
@@ -23,3 +23,3 @@
   work_group_commit_read_pipe(p, tmp);    // expected-error{{invalid argument type to function work_group_commit_read_pipe (expecting 'reserve_id_t')}}
-  sub_group_commit_write_pipe(p, tmp);    // expected-error{{nvalid pipe access modifier (expecting write_only)}}
Anastasia wrote:
> This test doesn't seem to work correctly because it didn't detect that we were checking for the wrong error message!
> I am thinking it might be the issue of adding "-ferror-limit 100" to the RUN line as it might have stopped to diagnose after certain number of errors given. Could you please double check this?
I just checked it and I guess it's passing because it's doing substring check, so no need to add anything to the RUN line. Your change is fine here!


More information about the cfe-commits mailing list