[PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

Duncan P. N. Exon Smith via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 6 15:49:32 PST 2016


> On 2016-Feb-06, at 15:40, Eric Fiselier <eric at efcs.ca> wrote:
> 
>> > +// The "hash_value" function is tested as part of [path.compare]
>> > +// in class.path/path.members/path.compare.pass.cpp
>> > +int main() {}
>> 
>> Okay, I get the idea of the one above.  I'm guessing this is just how
>> we mark that something has been properly tested.
>> 
>> However, it uses up bot time to have these extra tests to compile, link,
>> and potentially shoot down to devices and pass output/exit status back.
>> Is there any way of marking these things as "tested elsewhere" without
>> adding load to the bots?
>> 
> 
> Maybe? I'm not sure this review is a good place for that discussion.

Probably not, just happened to notice it here.

> FWIW I don't think these actually slow down the bots a noticeable amount.

I'm planning to set up bots that do on-device testing using the
SSHExecutor.  From my initial testing it looks like there's a
non-neglible overhead per-test, so I think it might be worth
optimizing this.  Sounds like you're not really attached, so if
I confirm it's an issue I'll come up with some alternate proposal.


More information about the cfe-commits mailing list