[PATCH] D16948: [libcxx] Filesystem TS Part 1 -- path

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 6 15:11:35 PST 2016


EricWF added a comment.

In http://reviews.llvm.org/D16948#345722, @dexonsmith wrote:

> Light review below, looks like great work.
>
> I noticed the tests seem somewhat inconsistent about whether to
>  glue `&` to the type or use two spaces (i.e., ` & `).  Which one is
>  preferred in this codebase?  Or is it laissez-faire?


I prefer it glued to the type *i think* but there is no set style currently. I'll try and make it more consistent as I see them.

> The rest of my comments are inline.


Thanks! If I could bother you to put them on phab next time instead of email it really helps me track them.


http://reviews.llvm.org/D16948





More information about the cfe-commits mailing list