[PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Xiuli PAN via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 26 21:04:02 PST 2016

pxli168 added inline comments.

Comment at: test/Parser/opencl-image-access.cl:9
@@ -7,1 +8,3 @@
+#if CL20
 __kernel void f__rw(__read_write image2d_t a) { }
Anastasia wrote:
> Btw, I can see that read_write is now accepted even if -cl-std=CL1.1. So essentially you don't need to add CL20 checks here.
> But I might prepare a quick fix of it afterwards.  
Yes, this is what this patch added in. It will check if read_write used earlier than CL2.0 as the spec said.

Comment at: test/SemaOpenCL/invalid-access-qualifier.cl:11
@@ +10,3 @@
+#ifdef CL20
+void test4(read_write image1d_t i){} 
Anastasia wrote:
> this is being tested in test/Parser/opencl-image-access.cl already
I will remove it.


More information about the cfe-commits mailing list