[PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 26 04:36:28 PST 2016

Anastasia added a comment.

Xiuli, do you still plan to continue here?

I was just thinking if it would make sense to re-upload the review since the line numbers got broken due to full diff.

Also it would be nice to partition to several independent commits/reviews. Let's say:

- Blocks diagnostics
- invalid types: images, pipes
- Misc: atomics and implicit declaration

Or you could split the last one into two as well.

What do you think?

Comment at: include/clang/Basic/DiagnosticSemaKinds.td:593
@@ -592,2 +592,3 @@
+def err_no_declarators : Error<"declaration does not declare anything">;
 def ext_typedef_without_a_name : ExtWarn<"typedef requires a name">,
pxli168 wrote:
> Anastasia wrote:
> > I just can't understand the intention here. Could you give any code example or reference to spec?
> I will try,
Do you still plan to have it? We can discuss in a separate review if you wish to be able to proceed here.


More information about the cfe-commits mailing list