[PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 17:58:41 PST 2016

echristo added a comment.

Honestly if they've been reviewed like that internally I'm ok with you just committing them - especially if they look like this.

The only concerns I'd have are in the case of "This intrinsic corresponds to the <blank> instruction" (side note, use the "the"? I commented on a case inline). This isn't always the case with all of our intrinsics when the compiler lowers them to a shuffle intrinsic or some such, or it's optimized, etc. Personally I'd leave that line out, though I understand it exists in a lot of similar documentation.


Comment at: lib/Headers/__wmmintrin_pclmul.h:37
@@ +36,3 @@
+/// This intrinsic corresponds to \c VPCLMULQDQ instruction.
"corresponds to the" ?


More information about the cfe-commits mailing list