[PATCH] D15603: [OpenCL] Pipe type support

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 5 03:28:47 PST 2016


Anastasia accepted this revision.
Anastasia added a reviewer: Anastasia.
Anastasia added a comment.

LGTM!


================
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108
@@ +107,3 @@
+    PipeTy = llvm::PointerType::get(llvm::StructType::create(
+      CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc);
+  }
----------------
Yes, I think we might, otherwise I don't see how we are going to allows any element type (including user defined types) for pipe without adding a template like functionality to C parsing.


http://reviews.llvm.org/D15603





More information about the cfe-commits mailing list