[PATCH] D15603: [OpenCL] Pipe type support

Xiuli PAN via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 5 03:52:32 PST 2016


pxli168 added inline comments.

================
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108
@@ +107,3 @@
+    PipeTy = llvm::PointerType::get(llvm::StructType::create(
+      CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc);
+  }
----------------
Anastasia wrote:
> Yes, I think we might, otherwise I don't see how we are going to allows any element type (including user defined types) for pipe without adding a template like functionality to C parsing.
OK, I will send a patch only for these two builtin function (I don't think other pipe functions need to be built-in), and I think we can discuss about the function mangle for them, now I have a version without mangle and a hard code version.


http://reviews.llvm.org/D15603





More information about the cfe-commits mailing list