[PATCH] D15163: Attach maximum function count to Module when using PGO mode.

Easwaran Raman via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 16:24:20 PST 2015


eraman updated this revision to Diff 42797.
eraman added a comment.

Updated the patch addressing Justin's comments and a new test case.

(Should I open a new review thread since phabricator thinks this has been submitted?)


Repository:
  rL LLVM

http://reviews.llvm.org/D15163

Files:
  lib/CodeGen/CodeGenModule.cpp
  test/Profile/Inputs/max-function-count.proftext
  test/Profile/max-function-count.c

Index: test/Profile/max-function-count.c
===================================================================
--- /dev/null
+++ test/Profile/max-function-count.c
@@ -0,0 +1,9 @@
+// Test that maximum function counts are set correctly.
+
+// RUN: llvm-profdata merge %S/Inputs/max-function-count.proftext -o %t.profdata
+// RUN: %clang %s -o - -mllvm -disable-llvm-optzns -emit-llvm -S -fprofile-instr-use=%t.profdata | FileCheck %s
+//
+int main() {
+  return 0;
+}
+// CHECK: !{{[0-9]+}} = !{i32 1, !"MaxFunctionCount", i32 1}
Index: test/Profile/Inputs/max-function-count.proftext
===================================================================
--- /dev/null
+++ test/Profile/Inputs/max-function-count.proftext
@@ -0,0 +1,7 @@
+main
+# Func Hash:
+0
+# Num Counters:
+1
+# Counter Values:
+1
Index: lib/CodeGen/CodeGenModule.cpp
===================================================================
--- lib/CodeGen/CodeGenModule.cpp
+++ lib/CodeGen/CodeGenModule.cpp
@@ -374,8 +374,11 @@
     if (llvm::Function *CudaDtorFunction = CUDARuntime->makeModuleDtorFunction())
       AddGlobalDtor(CudaDtorFunction);
   }
-  if (PGOReader && PGOStats.hasDiagnostics())
-    PGOStats.reportDiagnostics(getDiags(), getCodeGenOpts().MainFileName);
+  if (PGOReader) {
+    getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+    if (PGOStats.hasDiagnostics())
+      PGOStats.reportDiagnostics(getDiags(), getCodeGenOpts().MainFileName);
+  }
   EmitCtorList(GlobalCtors, "llvm.global_ctors");
   EmitCtorList(GlobalDtors, "llvm.global_dtors");
   EmitGlobalAnnotations();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15163.42797.patch
Type: text/x-patch
Size: 1591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151215/e0605f62/attachment.bin>


More information about the cfe-commits mailing list