[PATCH] D15163: Attach maximum function count to Module when using PGO mode.

[Easwaran Raman via cfe-commits]

On Fri, Dec 11, 2015 at 6:12 PM, Justin Bogner <mail at justinbogner.com>
wrote:

> Easwaran Raman <eraman at google.com> writes:
> > eraman added a comment.
> >
> > I have reverted the commit in r255416 because the test failed in many
> > architectures.
>
> You also committed without waiting for further review, despite that
> David said "LGTM but please wait for other reviewers". Please don't do
> that in the future.
>

Sorry about that. I waited for a few days, but the right thing to do would
have been to explicitly ping the reviewers. Will do so in the future.

- Easwaran


> > In many cases the linker is not able to find
> > libclang_rt.profile-$ARCH.a file. There are also other errors. Here is
> > one:
> >
> > 0. Program arguments:
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/clang
> > -cc1 -triple hexagon-unknown--elf -emit-obj -disable-free
> > -main-file-name pgo-max-function-count.c -mrelocation-model static
> > -mthread-model posix -mdisable-fp-elim -fmath-errno -masm-verbose
> > -mconstructor-aliases -target-cpu hexagonv4 -mqdsp6-compat
> > -Wreturn-type -fshort-enums -mllvm -machine-sink-split=0
> > -target-linker-version 2.25 -dwarf-column-info
> > -fprofile-instr-generate -resource-dir
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../lib/clang/3.8.0
> > -internal-externc-isystem
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../../gnu/lib/gcc/hexagon/0.0.0/include
> > -internal-externc-isystem
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../../gnu/lib/gcc/hexagon/0.0.0/include-fixed
> > -internal-externc-isystem
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../../gnu/hexagon/include
> > -O2 -fdebug-compilation-dir
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/tools/clang/test/CodeGen
> > -ferror-limit 19 -fmessage-length 0 -fshort-enums -fno-signed-char
> > -fno-use-cxa-atexit -fobjc-runtime=gcc -fdiagnostics-show-option
> > -vectorize-loops -vectorize-slp -o
> > /tmp/pgo-max-function-count-816195.o -x c
> >
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.src/tools/clang/test/CodeGen/pgo-max-function-count.c
> >
> > <snip>
> >
> > Target: hexagon-unknown--elf
> >
> > Seems like the command line is messed up (I assume there should be a
> > space between hexagon-unknown and --elf).
> >
> > Any suggestions on how to fix this test case? AFAICT, there are no PGO
> > related tests in clang and I based this on PGO tests in compiler-rt/
>
> I'll comment on the patch, but you can't write tests in clang that
> attempt to compile and run the compiled binary.
>
> >
> > Repository:
> >   rL LLVM
> >
> > http://reviews.llvm.org/D15163
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151214/6edd3975/attachment.html>