[PATCH] D14744: PR10235: support for vector mode attributes + warning

[Dmitry Polukhin via cfe-commits]

DmitryPolukhin added a comment.

Thank you for prompt response!


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765
@@ +2764,3 @@
+def warn_vector_mode_deprecated : Warning<
+  "specifying vector types with __attribute__ ((mode)) is deprecated, "
+  "use __attribute__ ((vector_size)) instead">,
----------------
aaron.ballman wrote:
> How about:
> 
> "'mode' attribute is not supported for vector types; use the 'vector_size' attribute instead"
Both GCC and ICC support vector types in mode attribute with similar warning so for compatibility reasons it is better to implement it. Taking into account that detection of vector types is more than half of supporting them. I do agree that warning group is confusing. I was not able to find more suitable warning group so would you recommend to create new one for this warning?


http://reviews.llvm.org/D14744