[PATCH] D14744: PR10235: support for vector mode attributes + warning

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

I am a little bit confused -- this patch adds a deprecation warning for vector sizes and claims that the attribute is ignored (by placing it in the IgnoredAttributes group), but then provides the initial implementation for this functionality and makes use of the attribute. If it's deprecated, why implement the behavior? Better to say "we recognize this attribute and won't explode on it, but do not implement the functionality since it is deprecated."


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765
@@ +2764,3 @@
+def warn_vector_mode_deprecated : Warning<
+  "specifying vector types with __attribute__ ((mode)) is deprecated, "
+  "use __attribute__ ((vector_size)) instead">,
----------------
How about:

"'mode' attribute is not supported for vector types; use the 'vector_size' attribute instead"


http://reviews.llvm.org/D14744