[PATCH] D13048: Fix for merging decls in pragma weak

Alexander Musman via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 08:45:36 PDT 2015

amusman added inline comments.

Comment at: lib/Sema/SemaDeclAttr.cpp:5201
@@ -5200,5 +5200,3 @@
   if (FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
-    FunctionDecl *NewFD;
-    // FIXME: Missing call to CheckFunctionDeclaration().
     // FIXME: Mangling?
     // FIXME: Is the qualifier info correct?
aaron.ballman wrote:
> If we're in this code, any chance you can also look at the other FIXME statements? If not, that's fine -- this is still positive movement. But it's usually best to tackle all of these at once while it's fresh in someone's mind what's happening here.
I've got here through an existing test case that failed on assertion, not sure I can quickly write or find examples for the other fixme's... So, I'd prefer not to promise that :)


More information about the cfe-commits mailing list