[PATCH] D13048: Fix for merging decls in pragma weak

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 06:01:34 PDT 2015

aaron.ballman added inline comments.

Comment at: lib/Sema/SemaDeclAttr.cpp:5201
@@ -5200,5 +5200,3 @@
   if (FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
-    FunctionDecl *NewFD;
-    // FIXME: Missing call to CheckFunctionDeclaration().
     // FIXME: Mangling?
     // FIXME: Is the qualifier info correct?
If we're in this code, any chance you can also look at the other FIXME statements? If not, that's fine -- this is still positive movement. But it's usually best to tackle all of these at once while it's fresh in someone's mind what's happening here.


More information about the cfe-commits mailing list