[PATCH] __attribute__((enable_if)) and non-overloaded member functions

Ettore Speziale via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 21 10:31:17 PDT 2015


sorry for the late reply, I did not note this email …

> Sure. :)  Review is based off the attachment I grabbed from here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150824/136904.html

That’s correct.

> A few nits:
> - test/Sema/enable_if.cpp line 24: Please use __attribute__(( instead of __attribute((
> - Can we have a similar test for a function that returns an Incomplete? 

Sure. Also in that case, only the error about Incomplete is reported. Please check the attached patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: enable_if.diff
Type: application/octet-stream
Size: 3204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150921/e1a1f042/attachment-0001.obj>
-------------- next part --------------

Thank you very much,
Ettore Speziale

More information about the cfe-commits mailing list