[PATCH] __attribute__((enable_if)) and non-overloaded member functions

George Burgess via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 21 11:12:51 PDT 2015


> sorry for the late reply, I did not note this email …

No problem! :)

It looks like the attached patch is the same as the original one?

George

On Mon, Sep 21, 2015 at 10:31 AM, Ettore Speziale <speziale.ettore at gmail.com
> wrote:

> Hello,
>
> sorry for the late reply, I did not note this email …
>
>
> > Sure. :)  Review is based off the attachment I grabbed from here:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150824/136904.html
>
> That’s correct.
>
> > A few nits:
> > - test/Sema/enable_if.cpp line 24: Please use __attribute__(( instead of
> __attribute((
> > - Can we have a similar test for a function that returns an Incomplete?
>
> Sure. Also in that case, only the error about Incomplete is reported.
> Please check the attached patch.
>
>
>
>
> Thank you very much,
> Ettore Speziale
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150921/7f4d5975/attachment.html>


More information about the cfe-commits mailing list