[PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

John McCall via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 10 21:52:28 PDT 2015


rjmccall added a comment.

LGTM.


================
Comment at: lib/CodeGen/CGClass.cpp:1234
@@ -1233,1 +1233,3 @@
 
+static bool isInitilierOfDynamicClass(const CXXCtorInitializer *BaseInit) {
+  const Type *BaseType = BaseInit->getBaseClass();
----------------
"Initializer"

But I think you can just inline this into the one call site as BaseInit->getType()->getAsCXXRecordDecl()->isDynamicClass().


http://reviews.llvm.org/D12312





More information about the cfe-commits mailing list