[PATCH] D11361: [OpenMP] Target directive host codegen

John McCall via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 10 21:46:22 PDT 2015


rjmccall added a comment.

Sorry for putting off the final review on this; I was heads-down trying to get the alignment patch done.  It's looking good; obviously you'll need to update it to work with Addresses properly, but hopefully that won't be too much of a problem.

When you do, maybe you should start a new review; I think there's some way to do that in Phabricator that ties it to the old one.  Phabricator seems to not be very happy with the extent to which the code has changed, and the old comments now just make it harder to review the current patch.


http://reviews.llvm.org/D11361





More information about the cfe-commits mailing list