[PATCH] D11781: Refactored pthread usage in libcxx
Fulvio Esposito via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 10 15:16:58 PDT 2015
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+# if defined(__FreeBSD__) || \
+ defined(__NetBSD__) || \
> jroelofs wrote:
> > @espositofulvio: @ed meant this:
> > ```
> > #ifndef _WIN32
> > # include <unistd.h>
> > # if _POSIX_THREADS > 0
> > ...
> > # endif
> > #endif
> > ```
> > Which //is// the correct way to test for this.
> That being said, there have been discussions before about whether or not we should #include <unistd.h> in <__config>, with the conclusion being that we shouldn't.
> It would be better if this were a CMake configure-time check that sets _LIBCPP_THREAD_API, rather than these build-time guards.
Tried adding that as configure time checks, but then libcxxabi fails to compile because of the guard in __config to check that _LIBCPP_THREAD_API has beed defined when _LIBCPP_HAS_NO_THREADS is not.
As a side note: Is Windows the only OS which hasn't got unistd.h?
More information about the cfe-commits