[PATCH] D11781: Refactored pthread usage in libcxx
Jonathan Roelofs via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 10 13:48:57 PDT 2015
jroelofs added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+# if defined(__FreeBSD__) || \
+ defined(__NetBSD__) || \
> @espositofulvio: @ed meant this:
> #ifndef _WIN32
> # include <unistd.h>
> # if _POSIX_THREADS > 0
> # endif
> Which //is// the correct way to test for this.
That being said, there have been discussions before about whether or not we should #include <unistd.h> in <__config>, with the conclusion being that we shouldn't.
It would be better if this were a CMake configure-time check that sets _LIBCPP_THREAD_API, rather than these build-time guards.
More information about the cfe-commits