[PATCH] D11446: For loop style fix

Yaron Keren yaron.keren at gmail.com
Thu Jul 23 12:34:30 PDT 2015


yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.

BB very frequently is BasicBlock and I is Instruction, typically in loops

  for (... &BB : F)
    for (... &I : BB)

grep "&BB :" to see more examples. The variable name should really be BB to follow existing code conventions.

To clarify the type maybe it's better not using auto:

  for (const BasicBlock &BB : F)

It there is a coding guide on using auto? I didn't find in the LLVM Programmer’s Manual.


http://reviews.llvm.org/D11446







More information about the cfe-commits mailing list