[PATCH] D11446: For loop style fix

Piotr Padlewski prazek at google.com
Thu Jul 23 11:37:58 PDT 2015


Prazek added inline comments.

================
Comment at: lib/CodeGen/CGVTables.cpp:190-191
@@ -189,4 +189,4 @@
     // Fix up the returned value, if necessary.
-    for (llvm::Function::iterator I = Fn->begin(), E = Fn->end(); I != E; I++) {
-      llvm::Instruction *T = I->getTerminator();
+    for (auto &BBlock : *Fn) {
+      llvm::Instruction *T = BBlock.getTerminator();
       if (isa<llvm::ReturnInst>(T)) {
----------------
majnemer wrote:
> We all take issue with some part of the coding style but it is important that we all stick to it.
Yep, I hope my middle aproach with "BBblock" is similiar enough. Seriously name like BB for newbie like me doesn't give me any information more than 2 random letters 


http://reviews.llvm.org/D11446







More information about the cfe-commits mailing list