[PATCH] Remove duplicated alteration to getProgramPaths().

Chandler Carruth chandlerc at google.com
Tue Jun 16 14:23:57 PDT 2015


Just to be clear, this commit seems good to me, and I'm fine with it being
in, but please don't submit patches without review once you've asked for it.

On Tue, Jun 16, 2015 at 2:22 PM Chandler Carruth <chandlerc at google.com>
wrote:

> Doug, why did you commit this without review? That's not really cool after
> you've asked folks to code review it and without any update.
>
> On Tue, Jun 16, 2015 at 12:43 PM Douglas Katzman <dougk at google.com> wrote:
>
>> REPOSITORY
>>   rL LLVM
>>
>> http://reviews.llvm.org/D10444
>>
>> Files:
>>   cfe/trunk/lib/Driver/ToolChains.cpp
>>
>> Index: cfe/trunk/lib/Driver/ToolChains.cpp
>> ===================================================================
>> --- cfe/trunk/lib/Driver/ToolChains.cpp
>> +++ cfe/trunk/lib/Driver/ToolChains.cpp
>> @@ -42,10 +42,6 @@
>>  MachO::MachO(const Driver &D, const llvm::Triple &Triple,
>>                         const ArgList &Args)
>>    : ToolChain(D, Triple, Args) {
>> -  getProgramPaths().push_back(getDriver().getInstalledDir());
>> -  if (getDriver().getInstalledDir() != getDriver().Dir)
>> -    getProgramPaths().push_back(getDriver().Dir);
>> -
>>    // We expect 'as', 'ld', etc. to be adjacent to our install dir.
>>    getProgramPaths().push_back(getDriver().getInstalledDir());
>>    if (getDriver().getInstalledDir() != getDriver().Dir)
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150616/096748fa/attachment.html>


More information about the cfe-commits mailing list