<div dir="ltr">Just to be clear, this commit seems good to me, and I'm fine with it being in, but please don't submit patches without review once you've asked for it.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 16, 2015 at 2:22 PM Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Doug, why did you commit this without review? That's not really cool after you've asked folks to code review it and without any update.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 16, 2015 at 12:43 PM Douglas Katzman <<a href="mailto:dougk@google.com" target="_blank">dougk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10444&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=2_QfbQA2u127HqsipUb1wjvU4VkkICOm95buB30UrRo&s=Vz0VmvYhJtODziEJMROF0Zk9oYJHKERAy78oZEXRFrQ&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10444</a><br>
<br>
Files:<br>
  cfe/trunk/lib/Driver/ToolChains.cpp<br>
<br>
Index: cfe/trunk/lib/Driver/ToolChains.cpp<br>
===================================================================<br>
--- cfe/trunk/lib/Driver/ToolChains.cpp<br>
+++ cfe/trunk/lib/Driver/ToolChains.cpp<br>
@@ -42,10 +42,6 @@<br>
 MachO::MachO(const Driver &D, const llvm::Triple &Triple,<br>
                        const ArgList &Args)<br>
   : ToolChain(D, Triple, Args) {<br>
-  getProgramPaths().push_back(getDriver().getInstalledDir());<br>
-  if (getDriver().getInstalledDir() != getDriver().Dir)<br>
-    getProgramPaths().push_back(getDriver().Dir);<br>
-<br>
   // We expect 'as', 'ld', etc. to be adjacent to our install dir.<br>
   getProgramPaths().push_back(getDriver().getInstalledDir());<br>
   if (getDriver().getInstalledDir() != getDriver().Dir)<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=2_QfbQA2u127HqsipUb1wjvU4VkkICOm95buB30UrRo&s=yqRiXGFat5-pcFhs1ltiCluDJOMOyQRxQHW3fRfxPQo&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></blockquote></div>