[PATCH] Allow case-insensitive values for -mcpu for ARM in line with GCC.

[Craig Topper]

+    StringRef MCPU = StringRef(A->getValue()).lower();

lower returns an std::string which will be immediately deleted leaving the
MCPU StringRef pointing at stale memory. MCPU should be a std::string.

On Mon, Jun 1, 2015 at 10:02 AM, Richard Barton <richard.barton at arm.com>
wrote:

> My only observation is that you have changed the Krait codepath, but have
> not added a test for that.
>
> Otherwise LGTM.
>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D10162
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150601/b0832a6b/attachment.html>