<div dir="ltr"><span style="font-size:12.8000001907349px">+    StringRef MCPU = StringRef(A->getValue()).</span><span style="font-size:12.8000001907349px">lower();</span><br><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">lower returns an std::string which will be immediately deleted leaving the MCPU StringRef pointing at stale memory. MCPU should be a std::string.</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 1, 2015 at 10:02 AM, Richard Barton <span dir="ltr"><<a href="mailto:richard.barton@arm.com" target="_blank">richard.barton@arm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">My only observation is that you have changed the Krait codepath, but have not added a test for that.<br>
<br>
Otherwise LGTM.<br>
<span class=""><br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10162&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=9AOMPqoJTEH0VGAzd1tMH7HjPnXaU8nKsyPg6i37zws&s=T4fksJ2Gcp8V8FEwGwn5e71EYZ0iw_WBQxMwYUevKqI&e=" target="_blank">http://reviews.llvm.org/D10162</a><br>
<br>
</span>EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=9AOMPqoJTEH0VGAzd1tMH7HjPnXaU8nKsyPg6i37zws&s=FmrDyhTVxzHGVgJeoBbAGjqPP503IIB_YOPereCQvpM&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>