[PATCH] Teach llvm-lit about ENABLE_BACKTRACES

Pete Cooper peter_cooper at apple.com
Tue Feb 10 11:56:42 PST 2015


> On Feb 10, 2015, at 11:50 AM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> This seems like a generally good thing to do if we're testing backtraces.
> 
> Do you want to merge the REQUIRES lines? I don't feel strongly either way.
Didn’t know we could.  Thats useful.  I merged them and retested that it still works.
> 
> Feel free to commit whenever.
Thanks.  Its r228735

Pete
> 
> On Tue, Feb 10, 2015 at 11:13 AM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Hi Chandler, Owen
> 
> In your patches to LLVM which changed ThreadLocal and PrettyStackTrace, we ended up requiring ENABLE_BACKTRACES for PrettyStackTrace.
> 
> Trouble is, clang has 2 tests which check for the pretty stack trace on crashes.  This patch teaches lit about the ENABLE_BACKTRACES option, and updates those 2 tests to use that option.  Without this patch, clang fails to pass llvm-lit without back traces.
> 
> Thanks,
> Pete
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150210/dc3f27dc/attachment.html>


More information about the cfe-commits mailing list