<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 10, 2015, at 11:50 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com" class="">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">This seems like a generally good thing to do if we're testing backtraces.<div class=""><br class=""></div><div class="">Do you want to merge the REQUIRES lines? I don't feel strongly either way.</div></div></div></blockquote>Didn’t know we could. Thats useful. I merged them and retested that it still works.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">Feel free to commit whenever.</div></div></div></blockquote>Thanks. Its r228735</div><div><br class=""></div><div>Pete<br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Feb 10, 2015 at 11:13 AM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Chandler, Owen<br class="">
<br class="">
In your patches to LLVM which changed ThreadLocal and PrettyStackTrace, we ended up requiring ENABLE_BACKTRACES for PrettyStackTrace.<br class="">
<br class="">
Trouble is, clang has 2 tests which check for the pretty stack trace on crashes. This patch teaches lit about the ENABLE_BACKTRACES option, and updates those 2 tests to use that option. Without this patch, clang fails to pass llvm-lit without back traces.<br class="">
<br class="">
Thanks,<br class="">
Pete<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>