r226548 - Introduce SPIR calling conventions.
sameer.sahasrabuddhe at amd.com
Tue Jan 20 02:56:57 PST 2015
On 1/20/2015 4:24 PM, Sameer Sahasrabuddhe wrote:
> On 1/20/2015 4:16 PM, Alexander Kornienko wrote:
>> On Tue, Jan 20, 2015 at 11:33 AM, Alexander Kornienko
>> <alexfh at google.com <mailto:alexfh at google.com>> wrote:
>> On Tue, Jan 20, 2015 at 7:44 AM, Sameer Sahasrabuddhe
>> <sameer.sahasrabuddhe at amd.com
>> <mailto:sameer.sahasrabuddhe at amd.com>> wrote:
>> Added: cfe/trunk/test/CodeGenOpenCL/spir-calling-conv.cl
>> --- cfe/trunk/test/CodeGenOpenCL/spir-calling-conv.cl
>> <http://spir-calling-conv.cl> (added)
>> +++ cfe/trunk/test/CodeGenOpenCL/spir-calling-conv.cl
>> <http://spir-calling-conv.cl> Tue Jan 20 00:44:32 2015
>> @@ -0,0 +1,18 @@
>> +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown"
>> -emit-llvm -o - | FileCheck %s
>> +int get_dummy_id(int D);
>> +kernel void bar(global int *A);
>> +kernel void foo(global int *A)
>> +// CHECK: define spir_kernel void @foo(i32 addrspace(1)* %A)
>> + int id = get_dummy_id(0);
>> + // CHECK: %call = tail call spir_func i32 @get_dummy_id(i32 0)
>> This test fails
>> Please fix or revert.
>> Clarification: this test fails only in some configurations, thus it
>> doesn't look like a trivial typo in the test which I could fix myself.
>> This is blocking us, so I'm going to revert the revision.
> Okay, go ahead, then. Looking into it.
I just had a look, and the failure looks trivial. The test looks for
"%call" as the name of the call instruction, but that particular config
seems to produce an anonymous value. Could you retry with a different
pattern in the test? It will be hard to test this on my machine.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits