<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 1/20/2015 4:24 PM, Sameer
Sahasrabuddhe wrote:<br>
</div>
<blockquote class=" cite" id="mid_54BE33F5_4040406_amd_com"
cite="mid:54BE33F5.4040406@amd.com" type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<br>
<div class="moz-cite-prefix">On 1/20/2015 4:16 PM, Alexander
Kornienko wrote:<br>
</div>
<blockquote class=" cite"
id="mid_CAOweq9_x8sAu4g1fHnAdbAyW4AZzqFNv05P2vw7Z_srnP0Vh9w_mail_gmail_com"
cite="mid:CAOweq9+x8sAu4g1fHnAdbAyW4AZzqFNv05P2vw7Z-srnP0Vh9w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Tue, Jan 20, 2015 at 11:33 AM,
Alexander Kornienko <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:alexfh@google.com"
target="_blank">alexfh@google.com</a>></span>
wrote:<br>
<blockquote id="Cite_1233275" class="gmail_quote cite"
style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr"><br>
<div class="gmail_extra">On Tue, Jan 20, 2015 at 7:44
AM, Sameer Sahasrabuddhe <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:sameer.sahasrabuddhe@amd.com"
target="_blank">sameer.sahasrabuddhe@amd.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<div>
<div class="h5">
<blockquote id="Cite_7736214"
class="gmail_quote cite" style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex"><br>
Added: cfe/trunk/test/CodeGenOpenCL/<a
moz-do-not-send="true"
href="http://spir-calling-conv.cl"
target="_blank">spir-calling-conv.cl</a><br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenOpenCL/spir-calling-conv.cl?rev=226548&view=auto"
target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenOpenCL/spir-calling-conv.cl?rev=226548&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenOpenCL/<a
moz-do-not-send="true"
href="http://spir-calling-conv.cl"
target="_blank">spir-calling-conv.cl</a>
(added)<br>
+++ cfe/trunk/test/CodeGenOpenCL/<a
moz-do-not-send="true"
href="http://spir-calling-conv.cl"
target="_blank">spir-calling-conv.cl</a>
Tue Jan 20 00:44:32 2015<br>
@@ -0,0 +1,18 @@<br>
+// RUN: %clang_cc1 %s -triple
"spir-unknown-unknown" -emit-llvm -o - |
FileCheck %s<br>
+<br>
+int get_dummy_id(int D);<br>
+<br>
+kernel void bar(global int *A);<br>
+<br>
+kernel void foo(global int *A)<br>
+// CHECK: define spir_kernel void @foo(i32
addrspace(1)* %A)<br>
+{<br>
+ int id = get_dummy_id(0);<br>
+ // CHECK: %call = tail call spir_func i32
@get_dummy_id(i32 0)<br>
</blockquote>
<div><br>
</div>
</div>
</div>
<div>This <a moz-do-not-send="true"
href="http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/1183/"
target="_blank">test fails</a>. Please fix or
revert.</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Clarification: this test fails only in some
configurations, thus it doesn't look like a trivial typo
in the test which I could fix myself.</div>
<div><br>
</div>
<div>This is blocking us, so I'm going to revert the
revision.</div>
</div>
</div>
</div>
</blockquote>
<br>
Okay, go ahead, then. Looking into it.<br>
</blockquote>
<br>
I just had a look, and the failure looks trivial. The test looks for
"%call" as the name of the call instruction, but that particular
config seems to produce an anonymous value. Could you retry with a
different pattern in the test? It will be hard to test this on my
machine.<br>
<br>
Sameer.<br>
<br>
</body>
</html>