[PATCH][OPENCL][SPIR] introduce SPIR calling conventions
sameer.sahasrabuddhe at amd.com
Sun Jan 18 22:42:45 PST 2015
On 1/16/2015 8:33 PM, Pekka Jääskeläinen wrote:
> On 01/15/2015 05:28 AM, Sameer Sahasrabuddhe wrote:
>> This implements Section 3.7 from the SPIR 1.2 spec:
>> SPIR kernels should use "spir_kernel" calling convention.
>> Non-kernel functions use "spir_func" calling convention. All
>> other calling conventions are disallowed.
>> The patch works only for OpenCL source. Any other uses will need to
>> that kernels are assigned the spir_kernel calling convention correctly.
>> Note that the patch modifies how ASTContext determines the default
>> convention. This *may* need a closer look, but it does pass lit tests
>> on all
> It looks fine to me.
Is that an LGTM?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits