<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 1/16/2015 8:33 PM, Pekka
Jääskeläinen wrote:<br>
</div>
<blockquote class=" cite" id="mid_54B9282A_2000304_tut_fi"
cite="mid:54B9282A.2000304@tut.fi" type="cite">On 01/15/2015 05:28
AM, Sameer Sahasrabuddhe wrote:
<br>
<blockquote class=" cite" id="Cite_6223122" type="cite">
<br>
This implements Section 3.7 from the SPIR 1.2 spec:
<br>
<br>
SPIR kernels should use "spir_kernel" calling
convention.
<br>
Non-kernel functions use "spir_func" calling
convention. All
<br>
other calling conventions are disallowed.
<br>
<br>
The patch works only for OpenCL source. Any other uses will need
to ensure
<br>
that kernels are assigned the spir_kernel calling convention
correctly.
<br>
<br>
Note that the patch modifies how ASTContext determines the
default calling
<br>
convention. This *may* need a closer look, but it does pass lit
tests on all
<br>
targets.
<br>
</blockquote>
<br>
It looks fine to me.
<br>
<br>
</blockquote>
<br>
Is that an LGTM?<br>
<br>
Sameer.<br>
<br>
</body>
</html>