[libcxx] r225541 - Walter Brown sent a list of tests which needed 'additional includes' to match what was in the standard. Added these includes to the tests. No changes to the library or test results.

Marshall Clow mclow.lists at gmail.com
Fri Jan 9 18:46:37 PST 2015


> On Jan 9, 2015, at 5:52 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> 
> On Fri, Jan 9, 2015 at 12:32 PM, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
> On Fri, Jan 9, 2015 at 12:25 PM, Marshall Clow <mclow.lists at gmail.com <mailto:mclow.lists at gmail.com>> wrote:
> Author: marshall
> Date: Fri Jan  9 14:25:52 2015
> New Revision: 225541
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=225541&view=rev <http://llvm.org/viewvc/llvm-project?rev=225541&view=rev>
> Log:
> Walter Brown sent a list of tests which needed 'additional includes' to match what was in the standard. Added these includes to the tests. No changes to the library or test results.
> 
> Richard - would a modularized libc++ (you have the setup for that, yes?) help enforce the right header inclusions in these tests (& other code using libc++)?
> 
> I have such a module map, but I've not run the libc++ tests with it in a long time. IIRC it found a *lot* of missing #includes, many of which were cases where <a> "obviously" includes <b> (but actually isn't required to do so). I'll have another look.

Great!
Thanks.

— Marshall

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150109/498487bb/attachment.html>


More information about the cfe-commits mailing list