<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 9, 2015, at 5:52 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Fri, Jan 9, 2015 at 12:32 PM, David Blaikie <span dir="ltr" class=""><<a href="mailto:dblaikie@gmail.com" target="_blank" class="">dblaikie@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><span class="">On Fri, Jan 9, 2015 at 12:25 PM, Marshall Clow <span dir="ltr" class=""><<a href="mailto:mclow.lists@gmail.com" target="_blank" class="">mclow.lists@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: marshall<br class="">
Date: Fri Jan 9 14:25:52 2015<br class="">
New Revision: 225541<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225541&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=225541&view=rev</a><br class="">
Log:<br class="">
Walter Brown sent a list of tests which needed 'additional includes' to match what was in the standard. Added these includes to the tests. No changes to the library or test results.<br class=""></blockquote></span><div class=""><br class="">Richard - would a modularized libc++ (you have the setup for that, yes?) help enforce the right header inclusions in these tests (& other code using libc++)?<br class=""></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">I have such a module map, but I've not run the libc++ tests with it in a long time. IIRC it found a *lot* of missing #includes, many of which were cases where <a> "obviously" includes <b> (but actually isn't required to do so). I'll have another look.</div></div></div></div></div></blockquote><br class=""></div><div>Great!</div><div>Thanks.</div><br class=""><div class="">— Marshall</div><div class=""><br class=""></div></body></html>