[PATCH] Use the integrated assembler by default on PowerPC and SPARC

Rafael Espíndola rafael.espindola at gmail.com
Fri Jan 9 15:07:58 PST 2015


On 9 January 2015 at 18:02, Brad Smith <brad at comstyle.com> wrote:
> On 01/09/15 18:00, Rafael Espíndola wrote:
>>
>> On 9 January 2015 at 17:13, Brad Smith <brad at comstyle.com> wrote:
>>>
>>> On 01/07/15 22:13, Rafael Espíndola wrote:
>>>>
>>>>
>>>> How come you didn't notice the tests failing locally before committing?
>>>
>>>
>>>
>>> I didn't run the testsuite as it has been completely broken for awhile
>>> on OpenBSD from a commit from you.
>>
>>
>> That is no excuse for not running the tests. If you for any reason
>> cannot run the tests you should not commit patches.
>
>
> Then go ahead and revert the commit.

The one that broke the bots was reverted.

Having the tests pass is a requirement documented in
http://llvm.org/docs/DeveloperPolicy.html, so you really cannot commit
if you can't run the tests. When posting a patch next, please
explicitly say that you are unable to test it and that any reviewer
interested in it has to do the testing and commit.

Cheers,
Rafael




More information about the cfe-commits mailing list