[PATCH] Use the integrated assembler by default on PowerPC and SPARC

Brad Smith brad at comstyle.com
Fri Jan 9 15:02:59 PST 2015


On 01/09/15 18:00, Rafael EspĂ­ndola wrote:
> On 9 January 2015 at 17:13, Brad Smith <brad at comstyle.com> wrote:
>> On 01/07/15 22:13, Rafael EspĂ­ndola wrote:
>>>
>>> How come you didn't notice the tests failing locally before committing?
>>
>>
>> I didn't run the testsuite as it has been completely broken for awhile
>> on OpenBSD from a commit from you.
>
> That is no excuse for not running the tests. If you for any reason
> cannot run the tests you should not commit patches.

Then go ahead and revert the commit.

> It would be nice to get the bot fixed. I don't remember it ever being green.

There are some tests that have always been broken.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.





More information about the cfe-commits mailing list