[PATCH] [clang-tidy] Move -extra-arg handling to CommonOptionsProvider

Alexander Kornienko alexfh at google.com
Sun Nov 2 20:46:12 PST 2014


================
Comment at: lib/Tooling/CommonOptionsParser.cpp:141-142
@@ -93,2 +140,4 @@
   }
+  Compilations = llvm::make_unique<ArgumentsAdjustingCompilations>(
+      std::move(Compilations), ArgsBefore, ArgsAfter);
 }
----------------
klimek wrote:
> It seems to me like we'd want either this to take an ArgumentAdjuster instead of hard-coding to the args-before / args-after case?
This would make sense, if we make this compilation database wrapper public. But for this specific case the total amount of code is not larger than what would be needed for the ArgumentsAdjuster-based variant.

http://reviews.llvm.org/D6073






More information about the cfe-commits mailing list