[PATCH] [clang-tidy] Move -extra-arg handling to CommonOptionsProvider

Manuel Klimek klimek at google.com
Sun Nov 2 20:41:58 PST 2014


================
Comment at: lib/Tooling/CommonOptionsParser.cpp:141-142
@@ -93,2 +140,4 @@
   }
+  Compilations = llvm::make_unique<ArgumentsAdjustingCompilations>(
+      std::move(Compilations), ArgsBefore, ArgsAfter);
 }
----------------
It seems to me like we'd want either this to take an ArgumentAdjuster instead of hard-coding to the args-before / args-after case?

http://reviews.llvm.org/D6073






More information about the cfe-commits mailing list